feat(notifications): delete flows (PR 3/7)#514
Merged
Conversation
Contributor
|
✅ No issues found. Checked for bugs and CLAUDE.md compliance. |
This was referenced Jun 12, 2026
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
sarthak688
force-pushed
the
feat/notifications-mark-read
branch
5 times, most recently
from
July 1, 2026 13:32
aaaef48 to
5bdbf0a
Compare
Sarath1018
reviewed
Jul 1, 2026
sarthak688
force-pushed
the
feat/notifications-mark-read
branch
3 times, most recently
from
July 2, 2026 05:05
95b10b2 to
a0128d8
Compare
sarthak688
force-pushed
the
feat/notifications-delete
branch
from
July 2, 2026 07:55
a489927 to
fe38d8a
Compare
Contributor
|
✅ No issues found. Checked for bugs and CLAUDE.md compliance. |
vnaren23
reviewed
Jul 2, 2026
vnaren23
approved these changes
Jul 2, 2026
Sarath1018
approved these changes
Jul 2, 2026
…nal] Adds the two delete methods on top of the notifications foundation and mark-read flows already on main. Both POST to the NotificationEntry.DeleteBulk OData action; deleteAll uses the server-side deleteAll flag. Both methods are tagged @internal (consistent with the rest of the notification service) so no oauth-scopes entry is added. Tests: 4 unit tests (deleteByIds + deleteAll, success + error). No integration tests — these destructively mutate the inbox with no SDK-level undo. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sarthak688
force-pushed
the
feat/notifications-delete
branch
from
July 2, 2026 12:22
fe38d8a to
28f2e06
Compare
Contributor
|
✅ No issues found. Checked for bugs and CLAUDE.md compliance. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 3/7 in the Notification SDK stack. Rebased onto
main(foundation #512 and mark-read #513 are now merged).Adds the two delete methods. Both POST to the same
DeleteBulkOData action endpoint;deleteAlluses the server-sidedeleteAllflag.Methods Added
notifications.deleteByIds()deleteByIds(tenantId: string, notificationIds: string[]): Promise<NotificationDeleteResponse>notifications.deleteAll()deleteAll(tenantId: string): Promise<NotificationDeleteAllResponse>Both methods are tagged
@internal(consistent with the rest of the notification service), so nodocs/oauth-scopes.mdentry is added.Endpoint Called
deleteByIds()/deleteAll()notificationservice_/notificationserviceapi/odata/v1/NotificationEntry/UiPath.NotificationService.Api.DeleteBulkImplementation Notes
X-UIPATH-Internal-TenantIdheader on each call.notifcationIds(sic), notnotificationIds. The SDK preserves the typo to match the live API; the SDK's public surface uses the correct spelling.deleteByIdsrejects empty arrays at the server with HTTP 400 — documented in JSDoc; the SDK doesn't add a client-side guard to avoid drift if the server relaxes that constraint.deleteAllsends{ notifcationIds: [], deleteAll: true }— the server deletes everything for the acting user regardless.Example Usage
API Response vs SDK Response
deleteByIds{ success: true, data: { notificationIds } }deleteAll{ success: true, data: { all: true } }Verification
npm run typechecknpm run lintnpm run test:unitNo integration tests for the delete methods — they destructively mutate the inbox with no SDK-level undo and would be hostile to repeat-run CI. Covered by unit tests for SDK shape and by manual smoke tests for live behaviour.
Files
src/utils/constants/endpoints/notification.ts(DELETE_BULK)src/models/notification/notifications.types.ts(response types),src/models/notification/notifications.models.ts(ServiceModel methods)src/services/notification/notifications.tstests/unit/services/notification/notifications.test.ts(+4 tests)tests/integration/shared/notification/notifications.integration.test.ts(note added explaining why no tests)PR Stack
feat/notifications-sdkfeat/notifications-mark-readfeat/notifications-delete(this PR)feat/subscriptions-sdkfeat/subscriptions-topic-updatesfeat/subscriptions-publisher-updatesfeat/subscriptions-mode-reset🤖 Generated with Claude Code